Skip to content

Document Database Setup and Migrations #2994

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 3, 2025
Merged

Document Database Setup and Migrations #2994

merged 3 commits into from
Apr 3, 2025

Conversation

gbirke
Copy link
Member

@gbirke gbirke commented Oct 7, 2024

How to integrate a database change from a bounded context in the Fundraising Application

The Fundraising Application has two different database environments:

- The **local development environment**. We're running a MariaDB database in a Docker container for local user and acceptance testing. We are using an in-memory SQLite database for running unit tests. This makes running the tests fast and allows for a clear separation between interactive testing and automated testing.
- The **server environment** has a dedicated database server with two databases (test and production) that our test and production web servers connect to. The Fundraising App and the Fundraising Operation Center both share the same production or testing database.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- The **server environment** has a dedicated database server with two databases (test and production) that our test and production web servers connect to. The Fundraising App and the Fundraising Operation Center both share the same production or testing database.
- The **server environment** is running on a dedicated database server with two databases (test and production) that our test and production web servers connect to. The Fundraising App and the Fundraising Operation Center both share the same production or testing database.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, maybe "consists of" or just "uses"? Pinging @Abban for a comment

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"Consists of" is good

2. Run CI and fix failing tests.
3. Run the database migration on the *old* version of the database schema
4. User-test the changed database (to check if the migrated database is correct)
5. Re-generate SQL for the local environment.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

does this point refer to ### Regenerating the local SQL ? Maybe we could link there or add the command here as well

@moiikana moiikana self-requested a review October 8, 2024 14:44
Copy link
Contributor

@moiikana moiikana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see comments above for suggestions/change requests

gbirke and others added 2 commits October 9, 2024 13:50
Co-authored-by: Co <corinna.hillebrand@wikimedia.de>
Co-authored-by: Co <corinna.hillebrand@wikimedia.de>
@Abban Abban merged commit 0ae0d84 into main Apr 3, 2025
4 checks passed
@Abban Abban deleted the document-migrations branch April 3, 2025 04:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants